Add N+1 query specs for the snippet index actions

What does this MR do?

This MR adds specs for guarding against N+1 queries in various snippets' controllers.

Does this MR meet the acceptance criteria?

Conformity

• 📋 Does this MR need a changelog?
  • I have included a changelog entry.
  • I have not included a changelog entry because this MR only touches tests.
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Related to #324704 (closed)