Remove legacy main.js behaviors
What does this MR do?
We have a special .remove-row class and .js-remove-tr class which would interact with rails-ujs events to remove a UI element after an asynchronous delete action was performed.
These were only used in a small handful of places. Furthermore, these special classes have stuck around in places where the rails-ujs functionality had since been removed.
This MR moves these helper behaviors directly into the page-specific javascripts where they are needed and removes them from main.js. It also removes vestigial instances of .remove-row and .js-remove-tr where they were included but did not do anything.
This is part of a larger effort to move jQuery out of our main.js bundle.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team