Make ref parameter optional in get raw file api
What does this MR do?
When setting compliance pipeline configuration path, the validation api checks if the file is present only in master branch.
The default branch can be overridden at project / group / instance level.
The validation will therefore always fail when the default branch is not master. This will prevent the Group owner from creating a compliance pipeline configuration path.
This MR fixes the validation by checking if the compliance pipeline configuration path exists in the project's default branch (HEAD).
This is acheived by marking the ref as an optional parameter in the Get file from repository api. If no value is provided, ref defaults to the HEAD of the project
Mentions #326923 (closed)
Screenshots (strongly suggested)
Compliance_configuration_file_validation_fix
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team