Centralize shared state in Authoring section
What does this MR do?
Instead of letting each tab handle very common state like EMPTY
and INVALID
, we add logic inside the editor-tab to potentially render generic components that can handle these states and prevent the slot component from being rendered. The way this was designed, the pipeline-editor-tabs
component is already subscribed to the appStatus
, so passing either isEmpty
or isInvalid
to the editor-tab
signal that you want the tab to handle that specific status.
Note that this allowed us to handle the case where the data is empty where we used to show an invalid error instead of a generic message. This MR doesn't introduce new UI element, though it create the plumbing necessary to make it work in the future (switching an alert for a whole screen for example).
Screenshots (strongly suggested)
Empty State
Before | After |
---|---|
Invalid state
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. - [-] I have not included a changelog entry because _____.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #321100 (closed)