Very first changes for loading JH extension
What does this MR do?
I thought we can finish !57807 (merged) before bring JH changes, but maybe a better first iteration would be just bringing the current changes here, since it's been there for some time already, and we can close the gap first.
We can see all the current JH changes at: gitlab-jh/gitlab@master...main-jh
This merge request bring changes outside of jh/ here, excluding CI changes because after gitlab-jh/gitlab#7 (closed) we should put CI changes over there instead of changing them directly.
/cc @qianzhangxa @jeromezng @kwiebers @meks
@gitlab-org/maintainers/rails-backend Please have a look at this, and I'll ask @rymai for the primary review.
@rymai Please review? Thanks! Feel free to wait for more feedback from other maintainers as well. It's ok to make some changes, and I'll bring JH synchronized with the new changes.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team