Small tweaks for navbar, tabs, and some other fixes
What does this MR do?
Some dark mode navbar, sidebar, and tab fixes. This has been broken since we split the themes into separate files
The navbar was only working due to stale styles in startup.css (related issue).
Moves dark mode nav rules from ui_light to application_dark. I don't love just dumping it in there, but this makes more sense than adding a darkmode to themes.rb since I want to support nav themes in dark mode soon anyway.
Screenshots (strongly suggested)
Nav text color, hover styles, dropdown content:
active tabs have underlines again!
Badge text is now white:
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Simon Knox