Skip to content

Small tweaks for navbar, tabs, and some other fixes

Simon Knox requested to merge psi-dark-navbar into master

What does this MR do?

Some dark mode navbar, sidebar, and tab fixes. This has been broken since we split the themes into separate files

The navbar was only working due to stale styles in startup.css (related issue).

Moves dark mode nav rules from ui_light to application_dark. I don't love just dumping it in there, but this makes more sense than adding a darkmode to themes.rb since I want to support nav themes in dark mode soon anyway.

Screenshots (strongly suggested)

Nav text color, hover styles, dropdown content:

Screen_Shot_2021-04-08_at_10.09.24_pm

active tabs have underlines again!

Screen_Shot_2021-04-09_at_9.51.21_am

Badge text is now white:

Screen_Shot_2021-04-08_at_10.08.50_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Simon Knox

Merge request reports

Loading