Skip to content

Create new way of encrypting tokens - phase 1 - reader

What does this MR do?

Creates new way of encrypting tokens.

After problems in https://gitlab.com/gitlab-com/gl-infra/production/-/issues/3443 we reached a decision to change a way to store encrypted tokens and stop using additional table and move to the system where nonce is saved in the same field as token.

This is phase one, we only roll out reader methods to avoid the same pitfalls. Next phase: writer, will be rolled out in the next milestone to provide possibility to deploy it to multiple nodes.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #322594 (closed)

Merge request reports

Loading