Update runner type indicators in view/edit pages
What does this MR do?
Fix for #327199 (closed)
This MR changes the page title and banner for runner view and edit pages.
In view pages:
- Update badge appearance with the type of runner (Group, Specific)
In edit pages:
- Add a new badge with the type of runner (Instance, Group, Specific)
- Update appearance of the alert and it's copy, that explain the type in more detail
Screenshots (strongly suggested)
In context:
Before | After |
---|---|
Copy text has been updated:
Before | After |
---|---|
The same alert and label has been applied to many different pages:
- Admin runner
- edit (e.g. http://gdk.test:3000/admin/runners/12)
- Group runner
- view (e.g. http://gdk.test:3000/groups/h5bp/-/runners/9)
- edit (e.g. http://gdk.test:3000/groups/h5bp/-/runners/9/edit)
- Project runner
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #327199 (closed)
Edited by Miguel Rincon