Use find rather than get verbiage for spec helpers
requested to merge dreedy-use-find-verbiage-instead-of-get-verbiage-for-spec-helper-methods into master
What does this MR do?
Uses a find
prefix to spec helpers which find elements or components rather than a somewhat ambiguous get
prefix which could be confused with a GET
API request, for example.
It also makes good sense to use find
because the underlying functions being used are wrapper.find
and wrapper.findComponent
.
This is kind of a follow up to #288015 (closed) & !51003 (merged), and is inspired by this comment
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because this is a developer-only facing change.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Dallas Reedy