Skip to content

Fix tests being skipped due to around hook

Doug Stull requested to merge dstull-fix-around-travel-to into master

What does this MR do?

  • Fixes tests being skipped due to around hook.
  • Found when executing the specs locally that all tests were skipped with this message:
❯ srspec spec/controllers/projects/project_members_controller_spec.rb
Running via Spring preloader in process 73493
WARNING: `around(:context)` hooks are not supported and behave like `around(:example). Called from /Users/dstull/projects/gdk/gitlab/spec/support/omniauth_strategy.rb:36:in `block in <main>'.
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
*********************************************

Pending: (Failures listed here are expected and do not affect your suite's status)

  1) Projects::ProjectMembersController GET index has the project_members address with a 200 status code
     # around hook at ./spec/controllers/projects/project_members_controller_spec.rb:10 did not execute the example
     # ./spec/controllers/projects/project_members_controller_spec.rb:15

Related to #300484 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Doug Stull

Merge request reports

Loading