Skip to content

Resolve "Investigate elevated `db_duration_s`during enabled `use_traversal_ids` FF"

What does this MR do?

Provide a way to call recursive namespace traversal queries even when the linear queries feature flag (use_traversal_ids) is enabled. This allows us to side step complications in roll out.

In EpicsFinder we force a #self_and_descendants recursive query over the linear query when the use_traversal_ids is true.

The recursive query:

WITH RECURSIVE "base_and_descendants" AS
    (
    (SELECT "namespaces".*
    FROM "namespaces"
    WHERE "namespaces"."type" = 'Group' AND "namespaces"."id" = 1)
UNION
    (SELECT "namespaces".*
    FROM "namespaces", "base_and_descendants"
    WHERE "namespaces"."type" = 'Group' AND "namespaces"."parent_id" = "base_and_descendants"."id"))
SELECT "namespaces".*
FROM "base_and_descendants" AS "namespaces"

The linear query:

SELECT "namespaces".*
FROM "namespaces"
WHERE (traversal_ids @>
  (SELECT traversal_ids as latest_traversal_ids
  FROM "namespaces"
  WHERE (id = (1)))
)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #327224 (closed)

Edited by Alex Pooley

Merge request reports

Loading