Skip to content

Move Service Templates nav link behind a feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

What does this MR do?

This MR is an iteration towards Service Template deprecation, as we prepare for complete removal of Service Templates in %14.0 (#325196 (closed) and &5672 (closed)). This MR specifically resolves #326962 (closed), by:

  • moving the Service Template nav item behind a feature flag (:disable_service_templates), disabled by default

It's worth noting that the actual Service Template page will still exist if the feature flag is enabled (i.e. users can still theoretically navigate to /admin/application_settings/services). Service templates are scheduled for complete removal in %14.1 (#325659 (closed) and #327091 (closed))

Feature flag rollout issue: #327436 (closed)

Screenshots (strongly suggested)

For user with no active service templates

Before After
Screen_Shot_2021-04-15_at_1.48.34_pm Screen_Shot_2021-04-15_at_1.48.47_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk

Merge request reports

Loading