Draft: Apply etag caching to pipeline status in pipeline editor
What does this MR do?
For #326085 (closed).
This updates the polling implementation for the pipeline status in the pipeline editor to use etag caching. This MR in particular does the following:
-
Pass the initial pipeline etag resource path to Vue. This is then saved in apollo cache so it can be updated later. -
Update the resource path in apollo when the user creates a new commit in the pipeline editor. Because a new pipeline is triggered, the resource path will change. The new path is provided in the CreateCommit
mutation response.
Screenshots
Instead of getting a bunch of 200
s when getPipeline
is polled, you should now see a bunch of 304
s while the pipeline status hasn't changed.
Before | After |
---|---|
Normal Polling |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Mireya Andres