Skip to content

Draft: Apply etag caching to pipeline status in pipeline editor

Mireya Andres requested to merge pipeline-etag-caching into master

What does this MR do?

For #326085 (closed).

This updates the polling implementation for the pipeline status in the pipeline editor to use etag caching. This MR in particular does the following:

  • Pass the initial pipeline etag resource path to Vue. This is then saved in apollo cache so it can be updated later.
  • Update the resource path in apollo when the user creates a new commit in the pipeline editor. Because a new pipeline is triggered, the resource path will change. The new path is provided in the CreateCommit mutation response.

Screenshots

Instead of getting a bunch of 200s when getPipeline is polled, you should now see a bunch of 304s while the pipeline status hasn't changed.

Before After
Normal Polling Cached Responses

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mireya Andres

Merge request reports

Loading