Skip to content

Support `per_repository` elector's health check failure message

Sami Hiltunen requested to merge smh-support-per-repository-health-check-failrue into master

What does this MR do?

Praefect's per_repository election strategy outputs a different log message when Praefect fails health checking a Gitaly node compared to the sql election strategy. The QA tests parse Praefect's logs to to identify when Praefect has failed a health check. As it's not looking for the new log messsage, the tests then fail as the suite doesn't identify the health check failure. This commit fixes the situation by also taking into account the message outputted by the per_repository election strategy.

Failed job: https://gitlab.com/gitlab-org/gitlab-qa/-/jobs/1171128894
Relevant log line in Praefect: https://gitlab.com/gitlab-org/gitaly/-/blob/d2802ba45eddcfdcc306d6457200002aa6453ee3/internal/praefect/nodes/health_manager.go#L250

Merge request reports