Fix images for pipeline empty state experiment
What does this MR do?
The experiment to show a list of CI templates on the pipelines empty state has a bug that I found in staging, where it didn't properly render the images, since they didn't go through the asset pipeline. This is fixing it now by supplying the list of CI templates from the backend instead using the image_path helper.
Previous MRs:
Issue: gitlab-org/growth/team-tasks#310 (closed)
Note: I wasn't able to test this on the review app unfortunately, although I set the feature flag. There is probably some caching going on that prevented me from rendering the experiment state.
Screenshots (strongly suggested)
| Before (on staging) | After |
|---|---|
 |
 |
How to test locally
Note: If the following does not work, try to restart the gdk to make sure no feature flag was cached.
echo 'Feature.enable(:pipeline_empty_state_templates)' | bin/rails c- Create or go to a project without a
.gitlab-ci.yml - Disabled "Default to Auto DevOps pipeline" in the CI/CD settings of your project (
http://localhost:3000/<group_name>/<project_name>/-/settings/ci_cd - Go to CI/CD -> Pipelines (
http://localhost:3000/<group_name>/<project_name>/-/pipelines
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because it is behind a feature flag.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team