Fix updating value stream record without stages
What does this MR do?
This MR fixes a bug when updating value streams with no associated stages. This can happen if the value stream was created before 13.9.
How to reproduce it:
- Make sure you're on ultimate
- Go to a group and record the id
- In rails console create a value stream:
Group.find(id).value_streams.create(name: 'test')
- Go to the Group -> Analytics -> Value Stream page
- Select the
test
value stream on the top right dropdown and click edit - Add a new stage on the bottom and try to save it.
Screenshots (strongly suggested)
Video: https://gitlab.slack.com/files/UH62Q221E/F01TKJBKJTZ/value_stream.mp4
Thanks @mvanremmerden for reporting it!
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Adam Hegyi