Skip to content

Revert: Enable submit by default in DAST Scanner Profile

What does this MR do?

This reverts an implementation from !56928 (merged) which enabled submit button by default to conform with design specs

What went wrong

  • This form (DAST Scanner Profile Form) did not have any client side form validations
  • This led to bugs like #327558 (closed)
    • required fields turned into optional field
    • although could have been avoided if backend had some default values set

Fix

  • Short term fix: Revert the UX enhancement for time-being as we're close to the release
  • Long term solution: Implement client-side validations (in progress - !59243 (merged)) and then enable the submit always

Screenshots (strongly suggested)

before after
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Dheeraj Joshi

Merge request reports

Loading