Skip to content

Fix querying repository blobs in GraphQL

Nick Thomas requested to merge fix-repository-blobs-query into master

What does this MR do?

Three problems, not picked up while reviewing this MR: !58677 (merged)

First, the args argument to resolver_complexity doesn't implement fetch, so any queries are currently broken.

Second, ::Blob type doesn't implement a couple of fields found in TreeEntry, and BlobType depends on them. So if you query for them from the new Blob endpoint, the query fails.

Third, sharing the GraphQL Blob type between the two endpoints is not practical.

Fix all three problems before a release, and introduce a feature spec to prevent the first two from recurring.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nick Thomas

Merge request reports

Loading