Add queue to background transaction metrics
What does this MR do?
In !56005 (merged), we introduced the background transaction metrics to capture the metrics inside the Sidekiq jobs. By default, the label for such kind of metrics includes two fields:
-
endpoint_id: name of the worker handles the job feature_category
This MR adds one more field, queue, into that label set. It is convenient, both long-term and short-term:
- In short-term, some dashboards related to Sidekiq are using queue as the identifier of the worker. There isn't a easy way to translate the worker name to the queue name in jsonnet. Hence, it's impossible to add more panels (like DB transaction, mentioned in #327616 (comment 550813589) for example) into such queue-based dashboards.
- In long-term, when we move to queue-per-shard, we'll need a way to look at from both worker and queue perspectives.
As a worker is translated into one queue, the cardinality of those metrics are not affected.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team