Display project runner identifiers consistently
What does this MR do?
This MR updates the runner identifiers (id and token) in the project settings view.
- Replaced
h4
monospace font and ellipsis in the runner token- Added some space between runners to make up for the margins lost
- Add runner id (e.g. #4 (closed)) to be at the same level as the token
- Moved the Edit (pencil button) to the right side to make space
Screenshots (strongly suggested)
Example URL: http://gdk.test:3000/h5bp/html5-boilerplate/-/settings/ci_cd
Before | After |
---|---|
What if there is a super long id number? (over 10 digits)
Responsive behavior
In some screens the layout is impacted. Note: Most of them are better than the before
!
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #326197 (closed)
Edited by Miguel Rincon