Skip to content

Reduce timeouts on SearchController#count to 5s

Dylan Griffith requested to merge 327106-reduce-timeout-on-search-count into master

What does this MR do?

The current timeout defaults to 15s. Per https://gitlab.com/gitlab-org/gitlab/-/issues/327106 this endpoint consumes a considerable amount of DB time. Since this endpoint is not as essential as the primary task the user is performing (since it is used to generate tab counts for other tabs you aren't searching) it makes sense to reduce the timeout so slower counts don't consume too much resources.

Screenshots (strongly suggested)

Screenshot_from_2021-04-15_12-28-35

Screenshot_from_2021-04-15_12-28-12

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #327106

Edited by Dylan Griffith

Merge request reports

Loading