Fix path for template logos
What does this MR do?
This fixes the path for the illustrations that we use for the Pipelines Empty State Experiment.
Previous MR where I already thought I fixed the problem (and it partially did by using image_path
instead): !59160 (merged)
I used the wrong path for the illustrations, and it didn't get picked up by the asset pipeline. Unfortunately I didn't catch this in the local environment. Now the path is fixed, which can be seen in the difference of the resulting URL of the image:
- Before:
/assets/illustrations/logos/android.svg
- After:
/assets/illustrations/logos/android-cdf2aa2a47a8c0149252b0dcae5a60dacf6b5fdea960037b323dacac0c287017.svg
How to test locally
Note: If the following does not work, try to restart the gdk to make sure no feature flag was cached.
echo 'Feature.enable(:pipeline_empty_state_templates)' | bin/rails c
- Create or go to a project without a
.gitlab-ci.yml
- Disabled "Default to Auto DevOps pipeline" in the CI/CD settings of your project (
http://localhost:3000/<group_name>/<project_name>/-/settings/ci_cd
- Go to CI/CD -> Pipelines (
http://localhost:3000/<group_name>/<project_name>/-/pipelines
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because it is behind a feature flag.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolas Dular