Skip to content

Add missing error returns

Jacob Vosmaer requested to merge jv-workhorse-seek into master

What does this MR do?

This adds missing error checks we overlooked while reviewing a security MR.

I think the function calls we forgot to check are unlikely to fail. But it is important to be consistent and handle all your errors.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading