Simple and optimized self_and_descendants query
What does this MR do?
The current Namespace#self_and_descendants
queries traversal_ids
and finds other namespaces with matching ancestors. This forces a subquery that confuses the PG11 optimizer.
To find self and descendants we only need to match the current node id
inside the traversal_ids
array. Without having to worry about ancestors we can avoid the subquery and avoid confusing the PG11 optimizer.
Old query:
SELECT "namespaces".*
FROM "namespaces"
WHERE (traversal_ids @>
(SELECT traversal_ids as latest_traversal_ids
FROM "namespaces"
WHERE (id = (9970))))
New query:
SELECT "namespaces".*
FROM "namespaces"
WHERE (traversal_ids @> ('{9970}'))
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because behind a feature flag.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #327224 (closed)
Edited by Alex Pooley