Skip to content

Resolve "Expose webhook data for Key via its own data-builder class"

Manoj M J requested to merge 290290-key-builder-class into master

What does this MR do?

For #290290 (closed)

This refactor helps to get all event data required for firing Key related webhooks from its own data-builder class, namely Gitlab::HookData::KeyBuilder so that this information is not private to SystemHooksService anymore.

No changelog added as this is only a refactor.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Manoj M J

Merge request reports

Loading