Skip to content

Expose enable_advanced_logs_querying in Environments API.

Vitali Tatarintev requested to merge 297340-improve-lcp-for-monitor-logs into master

What does this MR do?

Contributes to #297340 (closed)

Exposes enable_advanced_logs_querying in Environments API.

Bonus

Optimise specs by using let_it_be

Before

[TEST PROF INFO] Factories usage

 Total: 189
 Total top-level: 163
 Total time: 7.6027s
 Total uniq factories: 8

   total   top-level     total time      time per call      top-level time               name

      50          50        1.2948s            0.0259s             1.2948s        environment
      43          43        1.6213s            0.0377s             1.6213s               user
      34          34        0.2333s            0.0069s             0.2333s personal_access_token
      34          34        4.2133s            0.1239s             4.2133s            project
      13           0        0.3762s            0.0289s             0.0000s           ci_build
       7           1        0.4008s            0.0573s             0.2328s         deployment
       7           0        0.1649s            0.0236s             0.0000s        ci_pipeline
       1           1        0.0071s            0.0071s             0.0071s            license

After

[TEST PROF INFO] Factories usage

 Total: 81
 Total top-level: 55
 Total time: 1.9715s
 Total uniq factories: 8

   total   top-level     total time      time per call      top-level time               name

      34          34        0.4021s            0.0118s             0.4021s personal_access_token
      14          14        0.8065s            0.0576s             0.8065s        environment
      13           0        0.3906s            0.0300s             0.0000s           ci_build
       7           1        0.3911s            0.0559s             0.2324s         deployment
       7           0        0.1441s            0.0206s             0.0000s        ci_pipeline
       4           4        0.1830s            0.0457s             0.1830s               user
       1           1        0.3410s            0.3410s             0.3410s            project
       1           1        0.0065s            0.0065s             0.0065s            license

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #297340 (closed)

Edited by Vitali Tatarintev

Merge request reports

Loading