Skip to content

Search: Always show scope tabs regardless of tab selected

What does this MR do?

Related to #326470 (closed)

The Elasticsearch tabs (comments, code, commits, wiki) were only being shown if Elasticsearch is enabled for the search level (project, group, global) and if the selected tab was available in Elasticsearch. Currently if you move from a tab that is available in Elasticsearch (code) to a tab that isn't available (users), the Elasticsearch tabs would disappear.

This MR adds a new method to check whether the Elasticsearch tabs should be shown or not that only relies upon whether Elasticsearch is enabled for the search level (global, group, project). A new method was created because the original method was used for other things (such as showing whether Advanced Search was enabled in the UI).

Note: this only affects Group/Global search as the project search uses different logic for displaying tabs

Screenshots (strongly suggested)

Group - code search

image

Group - epics search

image

Group - users search

image

Global - users search

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Terri Chu

Merge request reports

Loading