Skip to content

Fix invite banner display for subgroups [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Jackie Fraser requested to merge fix-invite-banner-for-subgroups into master

What does this MR do?

Makes the "Invite your colleagues" banner display for a subgroup with the same member count rules as a parent group.

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/323106

Related to Internal issue

Screenshots (strongly suggested)

before after
The invite banner was displayed on a subgroup page. The banner says ("...you haven't invited anyone to this group. ") subgroup-invite-banner The subgroup members include the members of the parent group: subgroup-members The banner is no longer displayed when the subgroup has no separately added members but the subgroup includes members of the parent group after

The invite members banner is displayed on the Group Overview page when:

  • page viewer can admin group
  • group has 1 or fewer members including yourself
  • the group was not just created, so there is no "Group successfully created" flash message also on the page in that spot.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jackie Fraser

Merge request reports

Loading