Skip to content

Don't drop time from timelogs.spent_at

Lee Tickett requested to merge retain-timelog-spent_at-time into master

What does this MR do?

At the moment we drop the time, and only record the date a timelog was spent at. This MR retains the time by no longer dropping it.

Previously, timelog system notes looked like:

image

Adding the time made them look "event worse":

image

So this MR also removes the unnecessary repetition of the date/time the spent time was logged at:

image

If time is added retrospectively, we still show the date:

image

As a follow up, we should probably consider supporting retrospective time logging with date and time (currently date only).

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lee Tickett

Merge request reports

Loading