Fix invite group form being shown when member locked
requested to merge 325339-invite-members-modal-old-form-is-shown-when-member-lock-is-enabled into master
What does this MR do?
Stops the invite-group form from being displayed on the Project Members page when the project's group has member lock (EE only feature) enabled
Resolves https://gitlab.com/gitlab-org/gitlab/-/issues/325339
Related to feature flag rollout: https://gitlab.com/gitlab-org/gitlab/-/issues/247208
Related to !60438 (merged)
Not including a changelog because the feature is still behind feature flag :invite_members_group_modal
Screenshots (strongly suggested)
before (when member_locked? (EE only)) |
after |
|---|---|
 |
 |
before (when not member_locked?) |
after (when can share with group but can not invite members) |
|---|---|
 |
|
Steps to reproduce
- Enable feature flag
Feature.enable(:invite_members_group_modal) - Create a group
- Create a project in the group
- Navigate to "Group" -> "Settings" -> "General" -> "Permissions, LFS, 2FA"
- Check "Prevent adding new members to project membership within this group" setting
- Navigate to the Project's "Members" page (see screenshots)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #325339
Edited by Jackie Fraser