Replace IncidentManagement::ProcessAlertWorker with a new version
What does this MR do?
Contributes to #224500 (closed)
Creates a new version of the IncidentManagement::ProcessAlertWorker
in order to remove the worker in the next major release. (See https://docs.gitlab.com/ee/development/sidekiq_style_guide.html#removing-workers)
We already deprecated the worker's first two arguments in !34948 (merged) We also have the issue to remove the deprecated parameters in %14.0
Even though the deprecation took place several releases ago (in %13.2) I'm trying to pick a safer path based on the following discussion. Where we replace the worker with the new one in %13.12 and then remove it in %14.0.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because it's a developer-facing change.
-
- [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team