Skip to content

ImportExport: Validate URL before downloading

What does this MR do?

All the current code paths that use Gitlab::ImportExport::CommandLineUtil#download helper already validates the URL before executing the download. But, since this method is a helper a new code path can be introduced without a validation. To avoid that, the validation will be done in the helper method itself.

Related to: !59033 (comment 557432133)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kassio Borges

Merge request reports

Loading