Skip to content

Add exclude_from_kubernetes tag to workers we run on VMs [RUN AS-IF-FOSS]

Sean McGivern requested to merge add-tags-for-sidekiq-workers-not-on-k8s into master

Currently, we have this mega-selector using queue names to decide what we run on our catchall shard vs VMs: https://gitlab.com/gitlab-com/gl-infra/k8s-workloads/gitlab-com/-/blob/207b7bd930cfb33cfabf6069a8b2444278a2af3f/releases/gitlab/values/values.yaml.gotmpl#L1003

It's pretty unwieldy and hard to understand. This MR adds the exclude_from_kubernetes tag to all the relevant workers not in that selector. This is because we want to go from 'new queues go to VMs by default, unless they happen to match one of the shards on k8s' to 'new queues always go to k8s by default': gitlab-com/gl-infra/scalability#998 (comment 560559021)

That means that the queues here are somewhat arbitrary: most of them are just queues we just happened to add during this migration that we don't have any particular reason to believe shouldn't run on k8s. But this way it's easier to talk about them 🙂

For gitlab-com/gl-infra/scalability#998 (closed).

Edited by Sean McGivern

Merge request reports

Loading