Refactor DAST Site Profile form
Related issue - #328376 (closed)
What does this MR do?
- This MR tries to fix an issue with toggling radio buttons within the
DAST Site Profile
form. The root cause of the issue is due to discrepancy with how its child component (DastSiteAuthSection
) communicates / updates the form data in the parent componentDastSiteProfileForm
.
-
DastSiteAuthSection
updates the form data on component creation, keeps both component in sync -
DastSiteAuthSection
updates the parent component with only required data, ie. serialized form fields & form state -
DastSiteAuthSection
receivesisEdit
state to distinguish between new form or updating an existing form.
Screenshots (strongly suggested)
before | after |
---|---|
bug | dast_site_radio_button_issue |
How to test this
- Enable the feature flag.
echo " Feature.enable(:security_dast_site_profiles_api_option)" | rails c
- Navigate to the DAST profile library page in your GDK:
/:namespace/:project/-/security/configuration/dast_profiles#site-profiles
- Select
create new site profile
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because the issue only affects the feature flaged feature.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Dheeraj Joshi