Skip to content

Start cleanup of "threads" page

Amy Qualls requested to merge 327754-aqualls-make-subdir into master

Begin the process of cleaning up the Threads (https://docs.gitlab.com/ee/user/discussions/) page. There will be lots of tendrils, and this MR will not finish the work. (cc to @phikai so he knows I've started, though) The threads page is wrong, but the destination page is ALSO wrong, so I have to start several seemingly-unrelated chess moves at once to eventually have a solid landing place for the items that need to move.

  • I started by looking at https://docs.gitlab.com/ee/user/discussions/ at Kai's request. He's right. Significant portions of this page belong with the merge requests portion of the IA.
  • So I looked at https://docs.gitlab.com/ee/user/project/merge_requests/reviewing_and_managing_merge_requests.html as I thought that would be the home of the content. The problem? It, too, is a mishmash.
    • Some of it is about managing merge requests themselves.
    • Some is about the process of reviewing merge requests.
    • That URL needs changing.
    • The stuff about managing merge requests themselves should be one level higher, part of explaining the concept of merge reviews.
  • Let's start somewhere. I reviewed the original discussions page, and spotted a seam where I could split some of the data apart.

So, the goals:

  • Move doc/user/project/merge_requests/reviewing_and_managing_merge_requests.md to doc/user/project/merge_requests/reviews/index.md. Let's start building a real home for this content.
  • Lift and shift what's in reviewing_and_managing_merge_requests.md to reviews/index.md. MAKE NO CONTENT CHANGES. The only revisions should be to image locations. If I make content changes here, this MR becomes unreviewable.
  • Move the images to go with the page that displays them.
  • Make the most obvious cut from doc/user/discussions/index.md - cleave off the suggestion-related data and put it in its logical home - this new directory. It becomes doc/user/project/merge_requests/reviews/suggestions.md.
  • LASTLY, update the in-UI links so we get a green pipeline.

In short: MOVE BUT DO NOT EDIT THE CONTENT. Editing is for content that lives on the right page. This content isn't there yet.

Related issues

Edited by Amy Qualls

Merge request reports