Skip to content

Get extra attributes from Spamcheck response and determine verdict [RUN ALL RSPEC][RUN AS-IF-FOSS]

Juliet Wanjohi requested to merge jwanjohi-spamcheck-monitor-mode into master

What does this MR do?

Returns system state as part of the Spamcheck response to show if monitorMode is on/off.

  • If monitorMode is true/on, we return the given verdict, log it then reassign it to a nil verdict because Spamcheck is not explicitly rendering verdicts.
  • If monitorMode is false/off, we continue with the rest of the spamcheck_verdict function logic.

Additionally, returns #spamcheck_verdict early if we get a NOOP verdict or monitorMode set to true from Spamcheck.

Related to:

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Ethan Urie

Merge request reports

Loading