Get extra attributes from Spamcheck response and determine verdict [RUN ALL RSPEC][RUN AS-IF-FOSS]
What does this MR do?
Returns system state as part of the Spamcheck response to show if monitorMode
is on/off.
- If
monitorMode
is true/on, we return the given verdict, log it then reassign it to anil
verdict because Spamcheck is not explicitly rendering verdicts. - If
monitorMode
is false/off, we continue with the rest of thespamcheck_verdict
function logic.
Additionally, returns #spamcheck_verdict
early if we get a NOOP verdict or monitorMode
set to true from Spamcheck.
Related to:
- gitlab-com/gl-security/engineering-and-research/automation-team/spam/spamcheck#60
- https://gitlab.com/gitlab-com/gl-security/engineering-and-research/automation-team/spam/spamcheck/-/issues/95
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Ethan Urie