Upgrade @gitlab/ui to v29.18.0
- Integration branch for gitlab-ui!2189 (merged)
What does this MR do?
Upgrades @gitlab/ui
to v29.18.0
. This contains a bootstrap-vue
upgrade to v2.17.3
and migrates the codebase as necessary.
Here are the BootstrapVue changes that affect us:
-
feat(b-table): add
sortKey
option forno-local-sorting
events: This affects a sortable table where we implemented some custom behavior based on asortKey
property.sortKey
is now part ofBTable
's API but a bug prevents us from using it for now, so we've switched toactualSortKey
instead. - fix(v-b-toggle): handle component updates on click listeners. The collapse directive only starts listening to click events after an animation frame, so we need to align with that here.
- A minor change in
BProgress
seems to be affecting some Jest snapshots in an insignificant way.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because this merge contains a ~"dependency update" .
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by David O'Regan