Skip to content

Fix continuous onboarding A SVG paths

Alper Akgun requested to merge aa/fix-continuous-onboarding-a-section-svg into master

What does this MR do?

Fix continuous onboarding A SVG image paths

They fail on production due to wrong asset image paths

Note that the following imagePath function is unfortunately not working properly in the production - followup MR to deprecate it

import { imagePath } from '~/lib/utils/common_utils';

Original MR !55380 (merged)

How to test locally

  • Enable one of the feature flags and disable the other one: Feature.enable_percentage_of_time(:learn_gitlab_a_experiment_percentage, 100)
  • Signup with a new user
  • Go to the "Learn Gitlab" or any other project
  • Click on "Learn Gitlab"

Troubleshooting

Since we require the "learn-gitlab" project to be available, which gets created in a background-job, it could be that the project didn't get created. This is because background-jobs are sometimes stuck in development. What to do then:

  • gdk stop
  • ps aux | grep runsv
    • If there is any other process beside grep, you need to run kill -9 <pid>
  • gdk start again and go through the sign up flow again.

Screenshots

screenshot-2021-05-04-22-13-58

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alper Akgun

Merge request reports

Loading