Skip to content

Continue untangling Threads and Reviews pages

Amy Qualls requested to merge 327754-aqualls-reviews-page into master

This merge request continues the work, originally identified in #327754 (closed), of issues with the Threads page.

  • https://docs.gitlab.com/ee/user/discussions/ contains subheadings that really belong with merge request reviews. https://docs.gitlab.com/ee/user/discussions/#merge-request-reviews and its sub-subheads, in particular.
  • I used the previous merge request for #327754 (closed) to position a "Merge request reviews" page in the right place, but the page contains a lot of content that really shouldn't live together.
  • Also, the info from the user/discussions page was a partial duplicate of some of the info in user/project/merge_requests/reviews/index.md. So I can't do a straight copy-and-paste. Instead: blending it all together.
  • The reviews page contained a pile of information about the Changes tab (why?) that should have been in its own page all along. Create user/project/merge_requests/changes.md to house that information and try to edit it as little as possible because this merge request is already getting brutal from a review standpoint. 😭 😭
  • Move all images to follow their content.

What this merge request does NOT do:

  • Put stubs in https://docs.gitlab.com/ee/user/discussions/ pointing to the moved information.
  • Update the left nav.
  • Finish cleaning up user/project/merge_requests/reviews/index.md - the top half is done but the second half deteriorates noticeably. More 😭 here.
  • Polish user/project/merge_requests/changes.md.

Related issues

Edited by Amy Qualls

Merge request reports