Improve performance of Project issues API
What does this MR do?
Removes unnecessary preloading of issue notes.
As seen in #211373 (comment 567476040), the query can be slow and it's also a waste of CPU and memory because we don't actually need it.
This also adds include_subscribed: false
to the related issues and epic issues API because the N+1 specs for those APIs were failing after I removed the preload. We actually do not intend to include subscription information in API endpoints that list multiple issues because this requires Markdown processing of all notes to get the participants.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #211373 (closed)
Edited by Heinrich Lee Yu