Fix: Apply VSA filters to records endpoint
What does this MR do?
This MR fixes 2 issues with filters in VSA where we noticed the filters were not correctly applying to the API
request for the stage data e.g /groups/gitlab-org/-/analytics/value_stream_analytics/value_streams/779/stages/2506/records
.
This MR fixes:
- Deep linking to a VSA stage with a selected label should apply the label to the request for stage data
/records
- Changing the date filters should refetch the stage data
NOTE: there's a separate issue with selecting multiple labels
Testing
- Navigate to group VSA ie. /groups/gitlab-org/-/analytics/value_stream_analytics
- Select a stage (Issue for example)
- Adjust the date filters (
/records
endpoint should be called with the start / end date) - Use the filter bar (
/records
endpoint should be called with the selected filters)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Ezekiel Kigbo