Skip to content

Allow redirect URLs for email campaign links

Nicolas Dular requested to merge nicolasdular/email-campaign-redirect into master

What does this MR do?

For issue: gitlab-org/growth/team-tasks#375

This is the first step to accept a redirect_to param and redirect to the given URL. We need this for the in-product marketing emails to count the amount of all clicks we receive. (right now, this only happens on the email's CTA)

In the next step, we will change the links to the docs we have in the InProductMarketing Emails to be gitlab.com/email_campaigns?redirect_to=https://docs.gitlab.com/some_page

Test

e.g. go to http://localhost:3000/groups/twitter/-/email_campaigns?series=0&track=create&redirect_to=https://docs.gitlab.com and get redirects to docs.gitlab.com

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolas Dular

Merge request reports

Loading