Use user_application_theme helper instead of hard-coded theme classes
requested to merge dreedy-use-user-application-theme-helper-instead-of-hard-coded-theme-classes into master
What does this MR do?
Makes use of the user_application_theme
helper method to return the proper UI theme CSS class name to use rather than relying on a hard-coded value (such as ui-indigo
).
This fixes a bug where these pages will render correctly for an unauthenticated person (because we don’t have a user-specific preference to load) and for a user with the default theme (indigo) set, but the pages will render without a nav-bar background color for all other users:
Screenshots
With a theme preference other than the default set, ui-light-indigo
in this case:
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because this is a developer facing change.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Jay Montal