Geo 2.0 Regression - Broken Popovers
What does this MR do?
Fixes #329827 (closed)
There were two bugs to be addressed here
-
By default the Progress Bars set the popover target by the title. There was a mistake and the verification and sync sections were using the same name causing the target to get confused. Correcting the popover title fixes this.
-
Since we hide/show the mobile/desktop views based on media breakpoints. The mobile and desktop components use the same naming convention. This causes the popovers to not work on mobile since it is targeting the hidden desktop version due to it being higher in the DOM tree. Adding a
target
prop to the popover component to be explicit about the popovers fixes this.
This change is also behind a feature flag (:geo_nodes:beta
)
How to test
- Set up a Geo Primary/Secondary GDK
- Fetch the current branch
- Activate the Feature Flag on your Primary GDK (
:geo_nodes_beta
) - Navigate to
http://127.0.0.1:3000/admin/geo/nodes_beta
- View UI
Screenshots (strongly suggested)
Bug | Fix | |
---|---|---|
Wrong Popover |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because change is behind a FF.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #329827 (closed)