Skip to content

Convert ref dropdown to Vue [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Samantha Ming requested to merge 327085-convert-ref-dropdown-to-vue into master
MR Changes
This MR Mount simple vue dropdown
TBD Connect dropdown with Vue router
TBD Add search to dropdown
TBD Update feature spec and ensure FF coverage
TBD Clean up: Remove Project.js

What does this MR do?

This MR series is an effort to convert the ref dropdown from HAML to Vue. This feature is built behind a FF, to allow us the flexibility to build it iteratively and in favor of smaller MR.

This MR is focused on mounting a simple vue dropdown in place of the original ref dropdown. Note: the dropdown won't actually update anything. That will be addressed in a follow-up MR. In this MR, we're just focused on the UI.

Testing case

This feature is behind a feature flag, to turn on:

rails c

Feature.enable(:vue_ref_dropdown)
  1. Navigate to Repository > Files
  2. You will see that the ref dropdown is using our PJ dropdown component
Close Open
image image

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #327085 (closed)

Edited by Samantha Ming

Merge request reports

Loading