Fix sort params in issues page refactor
What does this MR do?
This MR fixes the sort parameters in the issues page refactor (#322755 (closed)), which is behind the vue_issues_list
feature flag defaulted to off.
On the existing Haml page, the page reloads when a new sort option is chosen. In the Vue refactor, when a new sort option is chosen the list is updated via AJAX and the URL parameters are programmatically updated so that the page can be bookmarked like before.
In the Vue refactor, the URL parameters were updated to order_by=created_at&sort=desc
when sorting but in production it's actually sort=created_date
. This was identified when running the feature specs with the vue_issues_list
feature flag on. Also, the Priority, Label priority, Manual, and Blocking sort options only have one sort order on production, so these discrepancies were updated in the Vue refactor.
Changes to feature tests were made so that when the feature flag is removed, the specs for sorting will still pass.
Screenshots (strongly suggested)
No visual changes
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #322755 (closed)