Skip to content

Geo 2.0 Regression - Data Types

Zack Cuddy requested to merge 329818-geo-beta-fix-data-types into master

What does this MR do?

Fixes #329818 (closed)

Currently in the backend we are "hard-coding" the data types for SSF replicables. These data-types are how we determine which strategy they are using (Repository/Blob) in the frontend. This change adds helper methods on the 2 strategies to tell the frontend the true data type each replicable represents.

This change is also behind a feature flag (:geo_nodes:beta)

How to test

  1. Set up a Geo Primary/Secondary GDK
  2. Fetch the current branch
  3. Activate the Feature Flag on your Primary GDK (:geo_nodes_beta)
  4. Navigate to http://127.0.0.1:3000/admin/geo/nodes_beta
  5. View UI

Screenshots (strongly suggested)

Before After
Data Types Broken Fix

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #329818 (closed)

Edited by Zack Cuddy

Merge request reports

Loading