Wiki: Use FindAllCommits RPC to list page versions
What does this MR do?
The wiki interface to the Git data leverages the Wiki Service in Gitaly. This service uses LibGit2, and the Ruby sidecar. As such there's a maintainance burden to the Wiki RPCs.
This change changes the Gitaly RPC that the Wiki#versions call uses to
FinddAllCommits. This RPC uses Git itself, and as such will allow the
remove of the PageVersions RPC on the Gitaly side in the next release.
Furthermore, it's expected that this change resolves other bugs too, for
example: #330295 (closed) (comment 572087692)
In this instance, git-fsck(1) can inflate a ZLib'ed Git object, where
Libgit2 for some reason fails. While I don't yet know why Libgit2 fails,
leveraging the same implementation as git-fsck(1) should resolve it.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team