Skip to content

Audit and update buttons on ProfilesController#show"

What does this MR do?

Updates buttons and avatar layout in ProfilesController#show.

  • Use smaller avatar (from 160 → 96).
  • Better responsive layout for the Public avatar section.
  • Update Choose file button to use GlButton.
  • Use sentence case for Public avatar heading.
  • Update border color for input group prepended and appended buttons.
  • Left align *Update profile settings and Cancel buttons.
    • Increase space above buttons and make them feel more at a page level instead of the last content section.
  • Update Cancel button to use GlButton.

Screenshots

Before After
CleanShot_2021-05-11_at_12.17.24 CleanShot_2021-05-12_at_08.58.30
gdk.test_3003_-_profile gdk.test_3003_-_profile

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #273315 (closed)

Edited by Jeremy Elder

Merge request reports

Loading