Convert bootstrap tabs on group/members page to `GlTabs`
📖 What does this MR do?
Related to #324681 (closed), #230782 (closed), #230754 (closed)
Previously the group/project members page was comprised of 4 separate Vue applications that used Bootstrap tabs. As part of an effort to remove Bootstrap tabs from the codebase this MR coverts the group/project member page into 1 Vue application that uses GlTabs
.
This MR builds on top of a few other MRs:
💻 Local testing
- Create a group or project and navigate to
Group or Project
->Members
Groups
tab
How to add a group to the - Navigate to
Group or Project
->Members
- Click the
Invite group
tab
Invited
tab
How to add an invited member to the - Navigate to
Group or Project
->Members
- In the
GitLab member or Email address
enter an email that a user does not already own - Click
Invite "example@test.com" by email
Access requests
tab
How to add a user to the - Log in (or impersonate) a user that doesn't already have access to the group or project
- Navigate to the group or project overview
- Click
Request access
located below the project/group name
📷 Screenshots
Visual/functional changes are very minimal. Slightly lighter tab text, GitLab UI focus state
View | Before | After |
---|---|---|
Group members | ||
Group shared groups | ||
Group invited | ||
Group access requests | ||
Project members | ||
Project shared groups | ||
Project invited | ||
Project access requests |
🚦 Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. - [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman